Re: [PATCH] git config: Don't rely on regexec() returning 1 on non-match
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 5, 2007, 15:14 UTC
- Message-ID
- <Pine.LNX.4.64.0712051513570.27959@racer.site>
- In-Reply-To
- <1196867484-22188-1-git-send-email-B.Steinbrink@gmx.de>
Hi,
On Wed, 5 Dec 2007, Björn Steinbrink wrote:
Show 10 quoted lines
> Some systems don't return 1 from regexec() when the pattern does not > match (notably HP-UX which returns 20). Fortunately, there's the > REG_NOMATCH constant, which we can use as the expected return value > and test for that instead of "1 XOR retval". > > Bug identified by Dscho and H.Merijn Brand. > > Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de> > Tested-by: H.Merijn Brand <h.m.brand@xs4all.nl> > Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>
ACK
Ciao, Dscho