git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] Avoid double exec() in execv_git_cmd()

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 2, 2007, 12:24 UTC
Message-ID
<Pine.LNX.4.64.0712021221410.27959@racer.site>
In-Reply-To
<1196579005-5662-2-git-send-email-gitster@pobox.com>
Hi,
On Sat, 1 Dec 2007, Junio C Hamano wrote:
Show 7 quoted lines
> This avoids double exec() when execv_git_cmd() is used to spawn an
> external git command.
> 
> For this, execv_git_cmd() needs to be able to tell what's built-in.
> This is done by introducing a new function git_builtin_command() that
> checks the list of built-in commands and returns a pointer to the
> cmd_struct if found.  The same function is used from the git potty.

IMNSHO this does not buy us anything, compared to my patch series. Your patch is larger, distributes the responsibility for the builtins to two files instead of one, and since we control what is builtin and what not, is not really less fragile with respect to what needs to be initialised.

Besides, we lose a great opportunity to go in the direction of libification.

Ciao, Dscho

Previous: Junio C HamanoNext: Christian Couder
Message 4 of 5 in “Prepare execv_git_cmd() for removal of builtins from the filesystem”
  1. 1/3 Prepare execv_git_cmd() for removal of builtins from the filesystemJunio C Hamano, Dec 2, 2007
  2. 2/3 Avoid double exec() in execv_git_cmd()Junio C Hamano, Dec 2, 2007
  3. 3/3 git-shell: accept "git foo" formJunio C Hamano, Dec 2, 2007
  4. Johannes SchindelinDec 2, 2007
  5. Christian CouderDec 2, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.