git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix rev-list when showing objects involving submodules

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 12, 2007, 21:25 UTC
Message-ID
<Pine.LNX.4.64.0711122124500.4362@racer.site>
In-Reply-To
<alpine.LFD.0.9999.0711121231570.3062@woody.linux-foundation.org>
Hi,
On Mon, 12 Nov 2007, Linus Torvalds wrote:
Show 16 quoted lines
> On Mon, 12 Nov 2007, Johannes Schindelin wrote:
> > 
> > You mean something like
> > 
> > 		else if (S_ISREG(entry.mod) || S_ISLNK(entry.mod))
> > 
> > Hmm?  Sure, I have no preference there.
> 
> Maybe more along the line of something like this?
> 
> In general, I suspect we should try to start moving away from using the 
> "S_ISLNK()" like things for internal git state. It was a mistake to just 
> assume the numbers all were same across all systems in the first place.
> 
> So this just converts to the "object_type", and then uses a case 
> statement.
Sure.  Just add the test from my patch, and we're fixed.

Ciao, Dscho

Previous: Linus Torvalds
Message 5 of 5 in “Fix rev-list when showing objects involving submodules”
  1. Fix rev-list when showing objects involving submodulesJohannes Schindelin, Nov 11, 2007
  2. Sam VilainNov 12, 2007
  3. Johannes SchindelinNov 12, 2007
  4. Linus TorvaldsNov 12, 2007
  5. Johannes SchindelinNov 12, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.