Re: [PATCH] Fix rev-list when showing objects involving submodules
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 12, 2007, 21:25 UTC
- Message-ID
- <Pine.LNX.4.64.0711122124500.4362@racer.site>
- In-Reply-To
- <alpine.LFD.0.9999.0711121231570.3062@woody.linux-foundation.org>
Hi,
On Mon, 12 Nov 2007, Linus Torvalds wrote:
Show 16 quoted lines
> On Mon, 12 Nov 2007, Johannes Schindelin wrote: > > > > You mean something like > > > > else if (S_ISREG(entry.mod) || S_ISLNK(entry.mod)) > > > > Hmm? Sure, I have no preference there. > > Maybe more along the line of something like this? > > In general, I suspect we should try to start moving away from using the > "S_ISLNK()" like things for internal git state. It was a mistake to just > assume the numbers all were same across all systems in the first place. > > So this just converts to the "object_type", and then uses a case > statement.
Sure. Just add the test from my patch, and we're fixed.
Ciao, Dscho