Re: *[PATCH] builtin-commit: Refresh cache after adding files.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 10, 2007, 02:02 UTC
Message-ID: <Pine.LNX.4.64.0711100201310.4362@racer.site>
In-Reply-To: <7v640ari76.fsf@gitster.siamese.dyndns.org>

Hi,

On Fri, 9 Nov 2007, Junio C Hamano wrote:

Show 14 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > This discussion exposes a problem with add_files_to_cache()
> > function.
> > ...
> > And add_file_to_cache(), which calls add_file_to_index() on
> > the_index, does call the fill_stat_cache_info() to sync the stat
> > information by itself, as it should be.  I am still puzzled with
> > this.
> 
> Blech.  I think it is 0781b8a9b2fe760fc4ed519a3a26e4b9bd6ccffe 
> (add_file_to_index: skip rehashing if the cached stat already matches) 
> that broke "git add".  I get the same problem not just with "git add -u" 
> but also with an explicit "git add Makefile".

But I think that we still need to refresh the index. It outputs which files names were new, and which ones were removed. Otherwise git commit would be eerily silent on those.

Ciao, Dscho