Re: [PATCH 01/11] Fix memory leak in traverse_commit_list
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 9, 2007, 23:51 UTC
- Message-ID
- <Pine.LNX.4.64.0711092350440.4362@racer.site>
- In-Reply-To
- <7vmytnqbu2.fsf@gitster.siamese.dyndns.org>
Hi,
On Fri, 9 Nov 2007, Junio C Hamano wrote:
Show 16 quoted lines
> "Shawn O. Pearce" <spearce@spearce.org> writes:
>
> > diff --git a/list-objects.c b/list-objects.c
> > index e5c88c2..713bef9 100644
> > --- a/list-objects.c
> > +++ b/list-objects.c
> > @@ -170,4 +170,11 @@ void traverse_commit_list(struct rev_info *revs,
> > }
> > for (i = 0; i < objects.nr; i++)
> > show_object(&objects.objects[i]);
> > + free(objects.objects);
> > + if (revs->pending.nr) {
> > + revs->pending.nr = 0;
> > + revs->pending.alloc = 0;
> > + revs->pending.objects = NULL;
> > + free(revs->pending.objects);Umm. Isn't this the wrong way around? Should you not free() first, and then set to NULL?
Ciao, Dscho