Re: git-rev-list diff options broken

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 6, 2007, 23:33 UTC
Message-ID: <Pine.LNX.4.64.0711062330220.4362@racer.site>
In-Reply-To: <f329bf540711061414k1627521bvaf4a7a06460cc3fd@mail.gmail.com>

Hi,

On Tue, 6 Nov 2007, Han-Wen Nienhuys wrote:

Show 23 quoted lines

> the git-rev-list manpage says
> 
> 
> **
> Diff Formatting
> ~~~~~~~~~~~~~~~
> 
> Below are listed options that control the formatting of diff output.
> Some of them are specific to gitlink:git-rev-list[1], however other diff
> options may be given. See gitlink:git-diff-files[1] for more options.
> **
> 
> however, the source code says
> 
> 
> 	if ((!list &&
> 	     (!(revs.tag_objects||revs.tree_objects||revs.blob_objects) &&
> 	      !revs.pending.nr)) ||
> 	    revs.diff)
> 		usage(rev_list_usage);
> 
> so any attempt at showing diffs with git-rev-list will fail. What's
> the deal with this?

Probably you want to use "git log".

"git blame -L 585,589 builtin-rev-list.c" indicates that 8c1f0b44(Fix up rev-list option parsing) was responsible, which in turn indicates that it was intentional.

Hth, Dscho