git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Document that using -M without other diff options is not a good idea

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 1, 2007, 15:09 UTC
Message-ID
<Pine.LNX.4.64.0711011508490.4362@racer.site>
In-Reply-To
<1193929060-6183-1-git-send-email-vmiklos@frugalware.org>
Hi,
On Thu, 1 Nov 2007, Miklos Vajna wrote:
Show 21 quoted lines
> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
> ---
> 
> I just noticed that I used 'git log -M' in some scripts which is obviously bad.
> People should not use that option without other diff options.
> 
>  Documentation/diff-options.txt |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
> index b1f528a..ed827f8 100644
> --- a/Documentation/diff-options.txt
> +++ b/Documentation/diff-options.txt
> @@ -92,7 +92,9 @@
>  	Break complete rewrite changes into pairs of delete and create.
>  
>  -M::
> -	Detect renames.
> +	Detect renames. It's no good using this option if you don't use diff
> +	options like `--name-status`, `-p` or `--stat` as it will just slow
> +	down the revision walker.

As I remarked on IRC earlier, this will also show up in the man page of git-diff, too. Rather funny, no?

Ciao, Dscho

Previous: Junio C HamanoNext: Miklos Vajna
Message 7 of 8 in “Document that using -M without other diff options is not a good idea”
  1. Document that using -M without other diff options is not a good ideaMiklos Vajna, Nov 1, 2007
  2. Include diff options in the git-log manpageMiklos Vajna, Nov 1, 2007
  3. Miklos VajnaNov 12, 2007
  4. Miklos VajnaDec 4, 2007
  5. Junio C HamanoDec 4, 2007
  6. Junio C HamanoDec 5, 2007
  7. Johannes SchindelinNov 1, 2007
  8. Miklos VajnaNov 1, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.