git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] Build-in send-pack, with an API for other programs to call.

From
Daniel Barkalow <barkalow@iabervon.org>
Date
Oct 30, 2007, 01:19 UTC
Message-ID
<Pine.LNX.4.64.0710292119080.7357@iabervon.org>
In-Reply-To
<20071030011401.GU14735@spearce.org>
On Mon, 29 Oct 2007, Shawn O. Pearce wrote:
Show 26 quoted lines
> Daniel Barkalow <barkalow@iabervon.org> wrote:
> > -int main(int argc, char **argv)
> > +void setup_send_pack(struct send_pack_args *args)
> > +{
> > +	receivepack = args->receivepack;
> > +	verbose = args->verbose;
> > +	send_all = args->send_all;
> > +	force_update = args->force_update;
> > +	use_thin_pack = args->use_thin_pack;
> > +	dry_run = args->dry_run;
> > +}
> ...
> > +struct send_pack_args {
> > +	const char *receivepack;
> > +	int verbose;
> > +	int send_all;
> > +	int force_update;
> > +	int use_thin_pack;
> > +	int dry_run;
> > +};
> > +
> 
> Ick.  How about doing what I did with builtin-fetch-pack.c which
> was to copy the args into a global "static struct fetch_pack_args"
> and make the struct a bitfield with these boolean items as ":1"
> rather than a full int?
Yeah, that's better. I'll respin parts 3 and 4 that way.
	-Daniel
*This .sig left intentionally blank*
Previous: Shawn O. Pearce
Message 4 of 4 in “Build-in send-pack, with an API for other programs to call.”
  1. 3/4 Build-in send-pack, with an API for other programs to call.Daniel Barkalow, Oct 30, 2007
  2. Shawn O. PearceOct 30, 2007
  3. Shawn O. PearceOct 30, 2007
  4. Daniel BarkalowOct 30, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.