git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Be nice with compilers that do not support runtime paths at all.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 22, 2007, 10:52 UTC
Message-ID
<Pine.LNX.4.64.0710221149530.25221@racer.site>
In-Reply-To
<20071022064454.GV14735@spearce.org>
Hi,
On Mon, 22 Oct 2007, Shawn O. Pearce wrote:
Show 29 quoted lines
> Benoit SIGOURE <tsuna@lrde.epita.fr> wrote:
> > >On Oct 4, 2007, at 1:18 AM, Junio C Hamano wrote:
> > >>Benoit Sigoure <tsuna@lrde.epita.fr> writes:
> > >>
> > >>If we do not care about supporting too old GNU make, we can do
> > >>this by first adding this near the top:
> > >>
> > >>        ifndef NO_RPATH
> > >>        LINKER_PATH = -L$(1) $(CC_LD_DYNPATH)$(1)
> > >>        else
> > >>        LINKER_PATH = -L$(1)
> > >>        endif
> > >>
> > >>and then doing something like:
> > >>
> > >>	CURL_LIBCURL = $(call LINKER_PATH,$(CURLDIR)/$(lib))
> > >>	OPENSSL_LINK = $(call LINKER_PATH,$(OPENSSLDIR)/$(lib))
> > >>
> > >>to make it easier to read and less error prone.
> > >
> > >Yes.  I can rework the patch, but the question is: do you care  
> > >about old GNU make?  Can I rewrite the patch with this feature?
> > 
> > I know Junio is still offline but maybe someone else has an objection 
> > against this?
> 
> How old of a GNU make are talking about here?  The above is certainly a 
> lot nicer to read, but I'd hate to suddenly ship a new Git that someone 
> cannot compile because their GNU make is too old.

I seem to remember remember that we had some shell quoting in the Makefile, and it was "call"ed. That broke some setups, so we got rid of it.

*starting "git log -Scall Makefile"*: yep. It even was me fixing it, in 39c015c556f285106931e0500f301de462b0e46e.

Ciao, Dscho

Previous: Brian DessentNext: Brian Gernhardt
Message 12 of 14 in “Linking with -R (rpath) not supported on Darwin”
  1. Benoit SIGOUREOct 3, 2007
  2. Junio C HamanoOct 3, 2007
  3. Be nice with compilers that do not support runtime paths at all.Benoit Sigoure, Oct 3, 2007
  4. Steven GrimmOct 3, 2007
  5. Brian GernhardtOct 4, 2007
  6. Junio C HamanoOct 3, 2007
  7. Brian GernhardtOct 4, 2007
  8. Benoit SIGOUREOct 4, 2007
  9. Benoit SIGOUREOct 21, 2007
  10. Shawn O. PearceOct 22, 2007
  11. Brian DessentOct 22, 2007
  12. Johannes SchindelinOct 22, 2007
  13. Brian GernhardtOct 3, 2007
  14. Benoit SIGOUREOct 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.