Re: [PATCH] Add color to git-add--interactive diffs (Take 2: now without spurious line break!)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 14, 2007, 17:15 UTC
Message-ID: <Pine.LNX.4.64.0710141814100.25221@racer.site>
In-Reply-To: <EFADE863-FC59-4A50-B165-9D30D9648B97@wincent.com>

Hi,

On Sun, 14 Oct 2007, Wincent Colaiuta wrote:

Show 6 quoted lines

> > +sub parse_color {
> 
> You could simplify the manual escape sequence construction that you're 
> doing here by using Term::ANSIColor like the other patches did. I see 
> that git-send-email.perl uses that module too, so I guess depending on 
> that module is ok.

Wrong. Depending on that module is not correct, you always have to wrap it into an "if (<is_color>) {...}".

I use git add -i quite often, and I _never_ use git send-email. My guess is that I am not alone with that.

Ciao, Dscho