Re: [PATCH 5/7] Bisect: factorise some logging into "bisect_write".

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 14, 2007, 16:07 UTC
Message-ID: <Pine.LNX.4.64.0710141706440.25221@racer.site>
In-Reply-To: <20071014142948.9f08b8ed.chriscool@tuxfamily.org>

Hi,

On Sun, 14 Oct 2007, Christian Couder wrote:

Show 10 quoted lines

> diff --git a/git-bisect.sh b/git-bisect.sh
> index 847250c..e12125f 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -132,6 +131,7 @@ bisect_write() {
>  	esac
>  	echo "$rev" >"$GIT_DIR/refs/bisect/$tag"
>  	echo "# $state: "$(git show-branch $rev) >>"$GIT_DIR/BISECT_LOG"
> +	test -z "$nolog" && echo "git-bisect $state $rev" >>"$GIT_DIR/BISECT_LOG"
>  }

Isn't a nolog="$3" missing from bisect_write()?

Ciao, Dscho