git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH amend] git-config: handle --file option with relative pathname properly

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 12, 2007, 12:08 UTC
Message-ID
<Pine.LNX.4.64.0710121308040.25221@racer.site>
In-Reply-To
<20071012113251.29941.qmail@7584201f340355.315fe32.mid.smarden.org>
Hi,
On Fri, 12 Oct 2007, Gerrit Pape wrote:
> -	setup_git_directory_gently(&nongit);
> +	const char *file = setup_git_directory_gently(&nongit);

One last nit (because I did not see it earlier): please call the variable "prefix", not "file".

Other than that, I think your patch is obviously correct.

Thanks, Dscho

Previous: Gerrit Pape
Message 5 of 5 in “git-config: handle --file option with relative pathname properly”
  1. git-config: handle --file option with relative pathname properlyGerrit Pape, Oct 9, 2007
  2. Johannes SchindelinOct 9, 2007
  3. Johannes SixtOct 9, 2007
  4. git-config: handle --file option with relative pathname properlyGerrit Pape, Oct 12, 2007
  5. Johannes SchindelinOct 12, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.