Re: Adding color to git-add--interactive

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 10, 2007, 15:06 UTC
Message-ID: <Pine.LNX.4.64.0710101604350.4174@racer.site>
In-Reply-To: <20071009234020.GA20952@coredump.intra.peff.net>

Hi,

On Tue, 9 Oct 2007, Jeff King wrote:

Show 16 quoted lines

> On Tue, Oct 09, 2007 at 02:06:31PM +0100, Jonathan del Strother wrote:
> 
> > For me at least, adding color would make the interactive mode far more
> > readable.   I hacked in basic color support (just coloring PROMPT &
> > HEADER in list_and_choose, and the "Stage this hunk?" prompt) - which
> > helped a lot - but then reached the limits of my perl knowledge.  For
> > instance, I can't see a sensible way of reusing git-svn's
> > log_use_color function without importing the entire file, and I can't
> > figure out how you'd go about diff-coloring the hunks.  Is anyone with
> > more perl knowledge than me interested in taking this on?
> 
> Why don't you post what you have, and we can make comments on it?
> 
> As far as reusing code from git-svn, there is a 'Git.pm' module in the
> perl/ subdirectory. You can move the code there and 'use Git' in
> git-add--interactive.perl (git-svn already uses it).

I think the reason git-add--interactive does not use it is that some people (me included) experienced heavy problems with perl modules. However, I do not recall to which extent they have been solved. I guess when git-add--interactive goes Git.pm and stops working for me, I'll do my famous "aargh, I'll just make it a builtin" song.

Ciao, Dscho