Re: [PATCH] Support cvs via git-shell

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 10, 2007, 13:29 UTC
Message-ID: <Pine.LNX.4.64.0710101427160.4174@racer.site>
In-Reply-To: <20071009223538.GG31659@planck.djpig.de>

Hi,

On Wed, 10 Oct 2007, Frank Lichtenheld wrote:

Show 11 quoted lines

> On Tue, Oct 09, 2007 at 03:33:25PM +0100, Johannes Schindelin wrote:
> >  static struct commands {
> >  	const char *name;
> >  	int (*exec)(const char *me, char *arg);
> >  } cmd_list[] = {
> >  	{ "git-receive-pack", do_generic_cmd },
> >  	{ "git-upload-pack", do_generic_cmd },
> > +	{ "cvs", do_cvs_cmd },
> >  	{ NULL },
> 
> Maybe this should also allow git-cvsserver for completeness' sake?

Umm.  Why?

If you use a cvs client with :ext: protocol, it will call ssh (or rsh!) with the command "cvs server", not "git-cvsserver".

Only in setups where you set (IIRC) the environment variable "CVSSERVER" on the client to "git-cvsserver" will it call something different, but these setups exist already, and never used git-shell to begin with.

Ciao, Dscho