Re: [PATCH 2/5] Refactor struct transport_ops inlined into struct transport
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Sep 20, 2007, 02:33 UTC
- Message-ID
- <Pine.LNX.4.64.0709192226150.21941@iabervon.org>
- In-Reply-To
- <Pine.LNX.4.64.0709191409590.28395@racer.site>
On Wed, 19 Sep 2007, Johannes Schindelin wrote:
Show 28 quoted lines
> Hi,
>
> On Wed, 19 Sep 2007, Shawn O. Pearce wrote:
>
> > diff --git a/transport.c b/transport.c
> > index cc76e3f..d8458dc 100644
> > --- a/transport.c
> > +++ b/transport.c
> > @@ -44,8 +44,6 @@ static int disconnect_walker(struct transport *transport)
> > return 0;
> > }
> >
> > -static const struct transport_ops rsync_transport;
> > -
> > static int curl_transport_push(struct transport *transport, int refspec_nr, const char **refspec, int flags) {
> > const char **argv;
> > int argc;
> > @@ -431,18 +406,31 @@ struct transport *transport_get(struct remote *remote, const char *url)
> > ret->url = url;
> >
> > if (!prefixcmp(url, "rsync://")) {
> > - ret->ops = &rsync_transport;
> > + /* not supported; don't populate any ops */
> > +
>
> That is sneaky. What are the reasons to remove rsync support? I know it
> is deprecated, but I'd still like to have it, especially for initial
> clones on small-RAMed machines.It never got implemented in a way called from C. This is just removing the pointer to the empty struct where support would go. If anybody knows enough about interfacing with rsync to write the necessary functions, it can be restored.
-Daniel *This .sig left intentionally blank*