Re: commit summary, --pretty=short and other tools

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 18, 2007, 10:13 UTC
Message-ID: <Pine.LNX.4.64.0709181109130.28586@racer.site>
In-Reply-To: <46EF7BF7.3070107@op5.se>

Hi,

On Tue, 18 Sep 2007, Andreas Ericsson wrote:

Show 8 quoted lines

> const char *find_commit_subject_end(const char *commit_msg)
> {
> 	const char *dot, *paragraph_end;
> 		paragraph_end = strstr(commit_msg, "\n\n");
> 	dot = strchr(commit_msg, '.');
> 		return min_non_null(dot, paragraph_end); }
> 
> would probably get it right very nearly always.

Counterexample (not even mentioning the missing handling of NULL):

http://brick.kernel.dk/git/?p=qemu.git;a=commit;h=eb66d86e295cd5a8f13221589806e15db62a62fa

And no, the responsible developer showed a strong unwillingness to adapt to better tools and workflows.

Ciao, Dscho