Re: [PATCH 0/9] work-tree clean ups

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 1, 2007, 01:13 UTC
Message-ID: <Pine.LNX.4.64.0708010211071.14781@racer.site>
In-Reply-To: <7vbqdsdqfd.fsf@assigned-by-dhcp.cox.net>

Hi,

On Tue, 31 Jul 2007, Junio C Hamano wrote:

Show 18 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > There is not really much that can be done about step 6/9: if we are in a 
> > work tree: that does not mean that we are _not_ in the git_dir.  (And no, 
> > this does not break git-clean, as a work tree is a work tree is a work 
> > tree.  If the user was stupid enough to specify the same directory as 
> > GIT_DIR and GIT_WORK_TREE, then that is _her_ problem.  Git is a powerful 
> > tool, and you can harm yourself with it.  Tough.)
> 
> I think we might have a slight misunderstanding.  The "clean"
> issue that was raised in an ancient thread was this sequence:
> 
> 	$ git init
>         $ cd .git
>         $ git clean
> 
> It did not involve GIT_DIR (nor GIT_WORK_TREE as it was not even
> there).

I very much _did_ mean that case. When "git clean" is run in ".git/", it should not say that it is in the working tree. But I guess that my patch series is not really looking out for that; I'll make that an add-on patch. (But that _will_ have to wait until tomorrow afternoon.)

Ciao, Dscho