git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation/git-diff: remove -r from --name-status example

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 29, 2007, 12:24 UTC
Message-ID
<Pine.LNX.4.64.0707291323150.14781@racer.site>
In-Reply-To
<20070729121948.GA21983@coredump.intra.peff.net>
Hi,
On Sun, 29 Jul 2007, Jeff King wrote:
Show 14 quoted lines
> On Sun, Jul 29, 2007 at 01:04:13PM +0100, Johannes Schindelin wrote:
> 
> > The idea is this: when "--quiet" was given, we do not output anything, and 
> > therefore do not have to recurse into the directories, because we already 
> > know that there are differences when a _tree_ is different.  I do not 
> > remember all details of the "--quiet" implementation, but I think that it
> > 
> > - exits early (as you said)
> > 
> > - does not turn on "recursive" to avoid unnecessary work.
> 
> OK, looking through the code, this works _sometimes_. If I say "git-diff
> --quiet" then it will not recurse. If I say "git-diff -p --quiet" then
> it will (even though we never show the -p output).

That is expected behaviour. If you ask for it, it should be done (however silly it might be).

Show 5 quoted lines
> Since --quiet supersedes all output formats, I think it probably should 
> just clear the recursive option entirely. In which case rather than 
> special-casing quiet to avoid recursion in git-diff, we can simply turn 
> on recursion before parsing options (and it will get turned off 
> correctly by any diff options that need to do so).

No. Just think about "git diff -p -w --quiet". In some cases it _has_ to recurse.

Ciao, Dscho

Previous: Jeff KingNext: Jeff King
Message 15 of 18 in “Documentation/git-diff: remove -r from --name-status example”
  1. Documentation/git-diff: remove -r from --name-status exampleJeff King, Jul 29, 2007
  2. Linus TorvaldsJul 29, 2007
  3. Jeff KingJul 29, 2007
  4. Linus TorvaldsJul 29, 2007
  5. Junio C HamanoJul 29, 2007
  6. Jeff KingJul 29, 2007
  7. David KastrupJul 29, 2007
  8. Junio C HamanoJul 29, 2007
  9. Jeff KingJul 29, 2007
  10. Johannes SchindelinJul 29, 2007
  11. David KastrupJul 29, 2007
  12. Jeff KingJul 29, 2007
  13. Johannes SchindelinJul 29, 2007
  14. Jeff KingJul 29, 2007
  15. Johannes SchindelinJul 29, 2007
  16. Jeff KingJul 29, 2007
  17. Linus TorvaldsJul 29, 2007
  18. Jeff KingJul 29, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.