Re: [PATCH 0/2] another attempt at make_absolute_path()
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 27, 2007, 19:22 UTC
- Message-ID
- <Pine.LNX.4.64.0707272022090.14781@racer.site>
- In-Reply-To
- <11855634561516-git-send-email-bradford.carl.smith@gmail.com>
Hi,
On Fri, 27 Jul 2007, Bradford C Smith wrote:
Show 13 quoted lines
> Here's my attempt at make_absolute_path() and friends. I think this
> version handles symlinks cleanly to avoid problems with '..' path
> elements Junio pointed out recently.
>
> I built these with another patch I previously submitted to make
> git-config consistently use lockfile.c routines and tested it with the
> regular test suite plus some extra tests Junio sent to the list for
> checking git-config symlink handling.
>
> I also built a separate executable with just the path handling routines
> in it and spot-checked several cases to make sure it appeared to be
> working as expected. ('/', loop of symlinks, lots of extra slashes, .
> and .. elements, etc.)Heh. Just a couple of minutes after I sent my version...
Although I added tests, and you did not...
Ciao, Dscho