Re: [PATCH 4/5] Add test for sanitized work-tree behaviour

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 26, 2007, 14:05 UTC
Message-ID: <Pine.LNX.4.64.0707261503530.14781@racer.site>
In-Reply-To: <7vfy3b8wkp.fsf@assigned-by-dhcp.cox.net>

Hi,

On Thu, 26 Jul 2007, Junio C Hamano wrote:

Show 25 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > ...
> > @@ -3,90 +3,109 @@
> >  test_description='test separate work tree'
> >  . ./test-lib.sh
> >  
> > +i=1
> > +
> >  test_rev_parse() {
> > - ...
> > +	name="$1"
> > +	for option in --is-bare-repository --is-inside-git-dir \
> > +		--is-inside-work-tree --show-prefix
> > +	do
> > +		shift
> > +		test_expect_success "$name: $option" \
> > +			"test '$1' = \"\$(git rev-parse $option)\""
> 
> > +i=$(($i+1))
> > +test $i = $STOPI && gdb --args git rev-parse $option
> 
> Eh?

Yes, got me there. It was a real PITA to debug that thing, given that the tests were written in the spirit of Malbolge. So the easiest method to debug it was for me to "-i -v" the test, run it again with "STOPI=$n .. -v", and work out what was the intended behaviour, and whether to fix the test or the logic.

Will clean up.

Ciao, Dscho