Re: [PATCH 3/3] Teach "git branch" about --new-workdir

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 24, 2007, 12:42 UTC
Message-ID: <Pine.LNX.4.64.0707241337470.14781@racer.site>
In-Reply-To: <46A5DF1F.2030307@trolltech.com>

Hi,

On Tue, 24 Jul 2007, Marius Storm-Olsen wrote:

> The new-workdir feature doesn't *have* to be about symlinked .git/ 
> metainfo space, but could also be about symref'ed .git/ metainfo. (A 
> discussion was done in 2005s "Getting rid of symlinks in .git?", but the 
> conclusion was that it would slow it down too much? *ponder*)

Right. I would not do it as symrefs, but as a (potentially ugly, but small) change to have the git_dir set to the shared one, and only in case of config and HEAD resort to the new_worktree_git_dir.

This would probably be one variable in environment.c, exported in cache.h, set in config.c (which would say "new_worktree_git_dir = get_git_dir(); setup_new_git_dir(value);"), and the appropriate special handling in git_path() in path.c.

Show 5 quoted lines

> I think you're right in that this is probably not the appropriate itch 
> to scratch for a Windows developer to start with, and I have my own list 
> of issues to work on when I get the time. File stat'ing 
> (daemon/service), CRLF issues, de-SH'ifying commands, non-MinGW native 
> build of Git, etc.. Lots to keep my fingers busy :-)

;-)

BTW a friend reported a CRLF issue on Windows, _in spite_ of setting the gitattributes appropriately... Did you ever get something like that?

> Though, let me also say that I already love working with Git on Windows. 
> And I thank each and every one who's working on it, for providing such 
> an excellent tool.

Good to hear!

Ciao, Dscho