git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-tag.c: Fix two memory leaks and minor notation changes.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 21, 2007, 13:08 UTC
Message-ID
<Pine.LNX.4.64.0707211407450.14781@racer.site>
In-Reply-To
<46A1F858.7080405@gmail.com>
Hi,
On Sat, 21 Jul 2007, Carlos Rica wrote:
Show 14 quoted lines
> A repeated call to read_sha1_file was not freing memory
> when the buffer was allocated but returned size was zero.
> 
> Also, now the program does not allow many -F or -m options,
> which was a bug too because it was not freing the memory
> allocated for any previous -F or -m options.
> 
> Tests are provided for ensuring that only one option
> -F or -m is given. Also, another test is shipped here,
> to check that "git tag" fails when a non-existing file
> is passed to the -F option, something that git-tag.sh
> allowed creating the tag with an empty message.
> 
> Signed-off-by: Carlos Rica <jasampler@gmail.com>
Thank you very much!
Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>

Ciao, Dscho

Previous: Carlos Rica
Message 3 of 3 in “builtin-tag.c: Fix two memory leaks and minor notation changes.”
  1. builtin-tag.c: Fix two memory leaks and minor notation changes.Carlos Rica, Jul 21, 2007
  2. Carlos RicaJul 21, 2007
  3. Johannes SchindelinJul 21, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.