Re: [PATCH] Update listingblock monospace fix to support all docbook versions
- From
Julian Phillips <julian@quantumfyre.co.uk>
- Date
- Jul 20, 2007, 22:14 UTC
- Message-ID
- <Pine.LNX.4.64.0707202309220.16498@reaper.quantumfyre.co.uk>
- In-Reply-To
- <3A4230BE-5F05-4AE9-AAB3-3B66C30DEF76@silverinsanity.com>
On Fri, 20 Jul 2007, Brian Gernhardt wrote:
Show 10 quoted lines
>
> On Jul 20, 2007, at 8:06 AM, Julian Phillips wrote:
>
>> +while ($line = <>) {
>> + $line =~ s/^#GIT#SET#MAN#FONT#/.ft/;
>> + print $line;
>> +}
>
> Why not use `perl -pe "s/^#GIT#SET#MAN#FONT#/.ft/"` or an equivalent sed
> command in the Makefile instead of having this as a separate script?Only because my perl foo is too weak to know the perl form, and I didn't know how to get sed to replace unicode characters - which the original version of the script did. I rewrote the script in my lunchbreak after I failed to find any better way to solve the problem, and it didn't occur to me to move it to sed at that point.
However, given the other issues with docbook xsl 1.72 I think it would cleaner to simply say that git doesn't support 1.72. I wouldn't be surprised if other projects weren't taking that approach.
-- Julian --- It's computer hardware, of course it's worth having <g> -- Espy on #Debian