Re: [PATCH] git-submodule fixes for call to git config --get-regexp

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 20, 2007, 18:36 UTC
Message-ID: <Pine.LNX.4.64.0707201933360.14781@racer.site>
In-Reply-To: <7vsl7jvthk.fsf@assigned-by-dhcp.cox.net>

Hi,

On Fri, 20 Jul 2007, Junio C Hamano wrote:

Show 5 quoted lines

> "Chris Larson" <clarson@kergoth.com> writes:
> 
> > +       name=$(GIT_CONFIG=.gitmodules git config --get-regexp
> > '^submodule\..*\.path$' "^$path$" |
> >        sed -nre 's/^submodule\.(.+)\.path .+$/\1/p')

I wonder why it is a regular expression to begin with, since we seem to prefer shell patterns on paths.

However, _if_ we already go with regexps, why not just put it into the "sed" call, which is _already_ there, and leave "git config" alone? IOW call

	git config --get-regexp '^submodule\..*\.path$' |
		sed -nre 's/^submodule\.(.*$path.*)\.path .+$\1/p'

Hmm?

Ciao, Dscho