Re: [PATCH 1/2] filter-branch: provide the convenience functions also for commit filters

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 19, 2007, 01:16 UTC
Message-ID: <Pine.LNX.4.64.0707190215460.14781@racer.site>
In-Reply-To: <7vfy3l5jo4.fsf@assigned-by-dhcp.cox.net>

Hi,

On Wed, 18 Jul 2007, Junio C Hamano wrote:

Show 14 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > +this_script="$(cd "$(dirname "$0")"; pwd)"/$(basename "$0")
> > ...
> > +		filter_commit="SOURCE_FUNCTIONS=1 . \"$this_script\"; $OPTARG"
> 
> Hmmmmmm.
> 
> Care to enlighten why this is not just:
> 
> 	filter_commit="SOURCE_FUNCTIONS=1 . \"$0\"; $OPTARG"
> 
> Is it because you cd(1) around in the script, and it can be
> relative to where you started?

Yes.

Show 8 quoted lines

> In either case, are you quoting potential funnies (such as '"'
> or '\\') in "$0" sufficiently?  Exporting this_script variable,
> and changing the above to
> 
> 	filter_commit='SOURCE_FUNCTIONS=1 . "$this_script";'" $OPTARG"
> 
> to arrange the shell that is invoked with 'sh -c' to expand its
> value would make it smaller problem, I suspect.

Will do. You know, I do have my problems with correct quoting, and the way I did it in this patch was always good enough for me. Which does not mean much...

Ciao, Dscho