Re: Installation failure caused by CDPATH environment variable

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 12, 2007, 11:37 UTC
Message-ID: <Pine.LNX.4.64.0707121234390.4516@racer.site>
In-Reply-To: <86sl7u12m3.fsf@lola.quinscape.zz>

Hi,

[please Cc' me if you already quote me and answer directly to my message]

On Thu, 12 Jul 2007, David Kastrup wrote:

Show 18 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Wed, 11 Jul 2007, Wincent Colaiuta wrote:
> >
> >> [describes the typical CDPATH problem]
> >
> > You exported CDPATH.  You're guaranteed to run into problems with 
> > that.  I doubt that your patch catches all problems in git, and even 
> > if we tried to avoid breakage, you can only do so much about that.
> >
> > It is _wrong_ to export CDPATH.
> 
> But it is not our job to educate people about that.  So I'd just add
> something like
> 
> [ "X" = "X$CDPATH" ] || unset CDPATH # ignore braindamaged exports
> 
> to the top of possibly affected scripts and be done.

We have that already, and we're not done.

> A one-liner that makes this somebody else's problem (if at all) is worth 
> its weight in gold.

That is right. And a one-liner that pretends to be a solve-all, but is not, is worth its weight in lead.

I bet that in ten years we find yet another instance where exporting CDPATH, which you should not have done in the first place, breaks Git.

Ciao, Dscho "who chants wrong, wrong, wrong"