Re: [RFC] series headers

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 10, 2007, 13:56 UTC
Message-ID: <Pine.LNX.4.64.0707101452250.4047@racer.site>
In-Reply-To: <20070710132401.GJ2343@thunk.org>

Hi,

On Tue, 10 Jul 2007, Theodore Tso wrote:

Show 19 quoted lines

> In general a patch series goes through multiple cycles of
> improvements, where people send it out for review/comment, and then it
> gets fixed up, etc. etc.   So you don't want to just do this:
> 
> On Mon, Jul 09, 2007 at 11:57:21PM -0700, Junio C Hamano wrote:
> 
> >  $ work work work, commit commit commit, reorder and perfect
> >  $ git format-patch --with-cover origin..HEAD
> >  ... which notices --with-cover, and perhaps does
> >  ... $ git-shortlog origin..HEAD
> >  ... $ git diff --stat --summary origin..HEAD
> >  ... $ echo "*** BLURB HERE ***"
> >  ... to create 0/N which it did not do so far in
> >  ... 0000-cover-letter.txt
> >  $ $EDITOR 0000-cover-letter.txt
> >  $ git-send-email 0*.txt
> 
> Because you'll be sending out the 0000-cover-letter.txt multiple
> times, refining it (and the patches) as you go along.

And what is so wrong with

[insert before format-patch] $EDITOR my-cover-letter.txt

[replace $EDITOR 0000-cover-letter.txt] $EDITOR my-cover-letter.txt 
	0000-cover-letter.patch

and paste the changed text?

Of course, you can still hand roll something with a commit. Probably a squash merge of your patch series.

Ciao, Dscho