Re: [PATCH 4/4] Add git-rewrite-commits

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 9, 2007, 14:59 UTC
Message-ID: <Pine.LNX.4.64.0707091558090.5546@racer.site>
In-Reply-To: <20070709144248.GW1528MdfPADPa@greensroom.kotnet.org>

Hi,

On Mon, 9 Jul 2007, Sven Verdoolaege wrote:

Show 8 quoted lines

> On Mon, Jul 09, 2007 at 03:11:45PM +0100, Johannes Schindelin wrote:
> > On Mon, 9 Jul 2007, Sven Verdoolaege wrote:
> > > The current git-rewrite-commits will rewrite all SHA1's it can find,
> > > irrespective of any 'commit ' that may precede it.
> > 
> > Even abbreviated ones?
> 
> Yes.  I'll add that to the documentation.

That is definitely something you want to control. I have seen commit messages referencing certain hexadecimal numbers, and they were definitely no commit names. The shorter they are, the more likely they are to be rewritten by your magic.

Show 19 quoted lines

> > * rename the darned things to "filter" again.
> > 
> > * --write-sha1-mappings=<directory> (or --write-commit-mappings), possibly 
> >   defaulting to .git/mappings/.  Be careful not to overwrite an existing 
> >   such directory.
> > 
> > * change the semantics of the commit filter: the output is a list 
> >   (possibly empty) of replacement sha1's for this commit.
> > 
> > * if any filters are called, provide a script with convenience functions, 
> >   and an environment variable pointing to it.  These functions should 
> >   include:
> > 
> > 	* map
> > 	* commit
> > 	* save
> > 	* restore
> 
> Hmm... you're tricking me into write shell code.

Ah, oh well.  If you do the rest, I'll do the shell code.

Ciao, Dscho