Re: [PATCH] Make fetch-pack a builtin with an internal API

> Daniel Barkalow <barkalow@iabervon.org> writes:
> 
> > In addition to making fetch-pack a builtin, this allows it to be called 
> > directly from other built-in code without generating and parsing argument 
> > lists, which will be useful for builtin-fetch.
> >
> > Incidently, it makes git-fetch-pack not output lists of what it fetched 
> > when it fails.
> 
> That sounds sensible.
> 
> Hmmm.  incidentally it seems to do a bit more than that.
> 
> > @@ -663,15 +659,42 @@ static int fetch_pack_config(const char *var, const char *value)
> >  
> >  static struct lock_file lock;
> >  
> > -int main(int argc, char **argv)
> > +void setup_fetch_pack(const char *_uploadpack,
> > ...
> > +#if 0
> > +	git_config(fetch_pack_config);
> > +
> > +	if (0 <= transfer_unpack_limit)
> > +		unpack_limit = transfer_unpack_limit;
> > +	else if (0 <= fetch_unpack_limit)
> > +		unpack_limit = fetch_unpack_limit;
> > +#endif
> > +}
> 
> This has been moved elsewhere?  I do not see how the code now
> honors the configuration.