Re: [PATCH] Deprecate git-cherry

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 6, 2007, 21:21 UTC
Message-ID: <Pine.LNX.4.64.0707062212280.4093@racer.site>
In-Reply-To: <7vmyy9dzrr.fsf@assigned-by-dhcp.cox.net>

Hi,

On Fri, 6 Jul 2007, Junio C Hamano wrote:

Show 18 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > A cleaner alternative was introduced in v1.5.2~185^2~1, which not only
> > allows you to list the commits, but to inspect them, too:
> >
> > 	git log --cherry-pick <upstream>...[<head>]
> >
> > There is a functional difference, though: git cherry shows both 
> > directions, <upstream>...<head> and <head>...<upstream>, and prefixes
> > the commits with '+' and '-', respectively.
> >
> > 'git rev-list --cherry-pick <upstream>...[<head>]' only shows one 
> > direction, and does not prefix the commits.
> 
> Eh, --left-right anybody?
> 
> git-cherry is used by people's scripts, and I do not think
> deprecating is an option at least in the short term.

Okay, I should have been more precise.

Maybe there are some interesting scripts that use "git cherry". I'd like to see them (which does not mean that I vote for git-cherry removal). Personally, I use "git rev-list --cherry-pick", because it spares me one call to sed.

However, I do not think that there is much value in advertising it any more. There is much more value in "git log --cherry-pick", since you can get the commit messages and the patches by just adding one more flag (and absent any path parameter, that can be even _at the end_ of the command line, making it even more convenient).

So what I meat was: advertise "git log --cherry-pick" instead of "git cherry", since it is vastly more useful.

There is one real consequence on my common usage, though: It annoys me whenever I want to cherry pick a commit, which happens quite often, that the bash completion completes on this (for me) useless command. I would like to see that gone (but only after a grace period, evidently).

Ciao, Dscho