Re: [PATCH] filter-branch: Avoid an error message in the map function.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 4, 2007, 11:49 UTC
- Message-ID
- <Pine.LNX.4.64.0707041247520.4071@racer.site>
- In-Reply-To
- <468B8852.CB36968@eudaptics.com>
Hi,
On Wed, 4 Jul 2007, Johannes Sixt wrote:
Show 22 quoted lines
> Johannes Schindelin wrote: > > > > On Wed, 4 Jul 2007, Johannes Sixt wrote: > > > > > - test -r "$workdir/../map/$1" || echo "$1" > > > - cat "$workdir/../map/$1" > > > + test -r "$workdir/../map/$1" && > > > + cat "$workdir/../map/$1" || > > > + echo "$1" > > > > I think this does not do what you want. If I read it correctly, it will > > not do anything if $workdir/../map/$1 is not readable. I think you need > > this: > > > > (test -r "$workdir/../map/$1" && > > cat "$workdir/../map/$1") || > > echo "$1" > > > > But that is a little too cute, so I personally would prefer an > > if-then-else-fi, because that is the idea of that code snippet. > > It does do what I think it should do. I tested it.
Okay. But take me as an example of an average programmer. I got confused. Therefore I would greatly appreciate it, if it were written with if-then-else-fi, because I get less confused then.
Thanks, Dscho