Re: [PATCH 2/2] Check for IO errors after running a command

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 25, 2007, 13:20 UTC
Message-ID: <Pine.LNX.4.64.0706251413530.4059@racer.site>
In-Reply-To: <7vy7i8xtap.fsf@assigned-by-dhcp.pobox.com>

Hi Junio,

On Mon, 25 Jun 2007, Junio C Hamano wrote:

> I took the liberty of munging your two patches to follow your comments 
> above (it was a perfect guinea-pig opportunity for Johannes's "rebase 
> -i").

And? How was that experience?

I am actually quite pleased how it worked out in the end; I never understood the syntax of rebase, and stayed away from it for that reason. By reworking patch-series into rebase -i, I learnt it on the way, and find it actually quite useful.

One thing we might consider, however: when rebasing, the current branch gets updated at each step. Some might consider this a bug, and prefer rebase to work on a detached HEAD, and only update the branch at the end, so that <branchname>@{1} refers to the state _before_ rebase.

Thoughts?

Ciao, Dscho