Re: Stupid quoting...

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 19, 2007, 01:00 UTC
Message-ID: <Pine.LNX.4.64.0706190156110.4059@racer.site>
In-Reply-To: <86ir9l1ylc.fsf@lola.quinscape.zz>

Hi,

On Mon, 18 Jun 2007, David Kastrup wrote:

Show 12 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
> > David Kastrup wrote:
> >
> >> what is the point in quoting file names and their characters in 
> >> git-diff's output?
> >
> > 7-bit email.
> 
> I think it can be reasonably safely assumed that people using 8-bit
> characters in file names will not refrain from using them in the files
> themselves: [...]

However, please realise that chances are very good that none of these 8-bit unclean things show in the diff.

Besides, the proper fix would probably involve making none-8-bit-clean diffs binary diffs (for FORMAT_EMAIL only, of course).

> So I don't see what quoting such characters in file names is supposed to 
> buy with regard to diff output in 7-bit email.

But isn't that obvious? Even if the diffs are not 7-bit clean, which I consider as an error, quoting the file names is already half what is required.

Don't just throw away backwards compatibility, only because it does not fit your wishes.

Ciao, Dscho