Re: [PATCH] fsck: do not crash on tag objects which do not contain an empty line

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 7, 2007, 23:13 UTC
Message-ID: <Pine.LNX.4.64.0706080011430.4046@racer.site>
In-Reply-To: <200706080108.50042.johan@herland.net>

Hi,

On Fri, 8 Jun 2007, Johan Herland wrote:

Show 9 quoted lines

> On Friday 08 June 2007, Johannes Schindelin wrote:
> > 
> > The first empty line in a tag object separates the header from the 
> > message. If the tag object has no empty line, do not crash, but 
> > complain loudly instead.
> 
> Aren't tag objects _required_ to have an empty line separating the 
> headers from the body? At least I wrote the new tag code with that 
> assumption in mind.

Yes, evidently you did.

But even then, isn't it always better to not rely on such assumptions, but fail gracefully? The rest of Git's source code seems to be nicer to failures as this one, IMHO.

> Could this be related to the "error: char103: premature end of data" 
> you're seeing?

Definitely. It breaks even _fetching_.

Ciao, Dscho