Re: [PATCH] Accept dates before 2000/01/01 when specified as seconds since the epoch
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 7, 2007, 05:30 UTC
- Message-ID
- <Pine.LNX.4.64.0706070629180.4046@racer.site>
- In-Reply-To
- <46679320.6000309@vilain.net>
Hi,
On Thu, 7 Jun 2007, Sam Vilain wrote:
Show 19 quoted lines
> Junio C Hamano wrote: > > I vaguely recall hitting the same issue soon after date.c was > > done, and sending in a patch in the same spirit but with > > different implementation (I essentially duplicated that "seconds > > since epoch" without any cutoff as the last ditch fallback) long > > time ago (this was before I took git over; the patch was rejected). > > > > It almost makes me wonder if it is better to introduce a special > > syntax to denote "seconds since epoch plus timezone offset" for > > our Porcelain use, instead of keeping this arbitrary cut-off > > date which nobody can agree on and which forces us to roll back > > from time to time. For one thing, such a syntax would allow us > > to talk about a timestamp before the epoch. > > > > Perhaps > > > > "epoch" [-+] [0-9]+ " " [-+][0-9][0-9][0-9][0-9] > > Probably a good idea, though it would break cg-admin-rewritehist.
FWIW I don't think we have to care that much about cg-admin-rewritehist, since it lives on as git-filter-branch, and we can adapt it as we go.
Ciao, Dscho