Re: [PATCH] filter-branch: always export GIT_DIR if it is set
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 5, 2007, 17:27 UTC
- Message-ID
- <Pine.LNX.4.64.0706051823140.4046@racer.site>
- In-Reply-To
- <20070605164957.GA12358@moooo.ath.cx>
Hi,
On Tue, 5 Jun 2007, Matthias Lederhofer wrote:
Show 11 quoted lines
> diff --git a/git-filter-branch.sh b/git-filter-branch.sh > index 0c8a7df..f4cfbea 100644 > --- a/git-filter-branch.sh > +++ b/git-filter-branch.sh > @@ -313,9 +313,12 @@ workdir="$(pwd)" > > case "$GIT_DIR" in > /*) > + export GIT_DIR > + export GIT_WORK_TREE=. > ;;
Doesn't it strike somebody else as intrusive, if GIT_WORK_TREE has to touch that many places?
IMHO there should be a less intrusive, and possibly simpler, way to do it. I am not at all interested in that feature, and I don't want to suffer bugs from it either.
Ciao, Dscho