[PATCH] Update to SubmittingPatches
Make people aware of our testsuite, and of non-ASCII encodings.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
On Sat, 2 Jun 2007, Junio C Hamano wrote:
> Junio C Hamano <junkio@cox.net> writes:
>
> > Kristian Høgsberg <hoegsberg@gmail.com> writes:
> >
> >> Encode ' ' using '=20' even though rfc2047 allows using '_' for
> >> readability..
> >
> > Thanks.
> >
> > Your message was marked as iso-8859-1 even though it was utf-8
> > (your signed-off-by line), so I'll fix it up with your From:
> > header.
>
> Oh, another thing. Before you submit a patch, make sure the
> whole testsuite in t/ passes by running "make test".
We should remind people of both.
Documentation/SubmittingPatches | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index b5f2ecd..b6e5847 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -14,6 +14,8 @@ Checklist (and a short version for the impatient):
commit message (or just use the option "-s" when
committing) to confirm that you agree to the Developer's
Certificate of Origin
+ - make sure that you have tests for the bug you are fixing
+ - make sure that the test suit passes after your commit
Patch:
@@ -33,6 +35,8 @@ Checklist (and a short version for the impatient):
- if you change, add, or remove a command line option or
make some other user interface change, the associated
documentation should be updated as well.
+ - if your name is not writable in ASCII, make sure that
+ you send off a message in the correct encoding.
Long version:
--
1.5.2.2663.gd77e7-dirty
Johannes Schindelin <johannes.schindelin@gmx.de>