Re: [PATCH] Prevent megablobs from gunking up git packs

From: david@lang.hm <david@lang.hm>
Date: May 24, 2007, 17:23 UTC
Message-ID: <Pine.LNX.4.64.0705241020450.21766@asgard.lang.hm>
In-Reply-To: <20070524071235.GL28023@spearce.org>

On Thu, 24 May 2007, Shawn O. Pearce wrote:

Show 8 quoted lines

> Now #3 is actually really important here.  Don't forget that we
> *just* disabled the fancy "new loose object format".  It doesn't
> exist.  We can read the packfile-like loose objects, but we cannot
> write them anymore.  So lets say we explode a megablob into a loose
> object, and its 800 MiB by itself.  Now we have to send that object
> to a client.  Yes, that's right, we must *RECOMPRESS* 800 MiB for
> no reason.  Not the best choice.  Maybe we shouldn't have deleted
> that packfile formatted loose object writer...

when did the object store get changed so that loose objects aren't compressed?

if the problem is that the codepath for fetching does an uncompress followed by a compress then it would seem that this is a fairly easy problem to fix (how hard would it be to add the headers around the compressed object to make it look to the receiver like it's a pack with only one thing in it)

David Lang