Re: [PATCH 0/3] Remotes library, take 4

From: Daniel Barkalow <barkalow@iabervon.org>
Date: May 12, 2007, 19:37 UTC
Message-ID: <Pine.LNX.4.64.0705121531480.18541@iabervon.org>
In-Reply-To: <7vfy61zvtx.fsf@assigned-by-dhcp.cox.net>

On Sat, 12 May 2007, Junio C Hamano wrote:

Show 15 quoted lines

> Daniel Barkalow <barkalow@iabervon.org> writes:
> 
> > Updated for recent review. If remote section name starts with '/', it is 
> > ignored (like in 1.5.0). If a remote section option has no value, it is 
> > also ignored (so it doesn't crash, and to be forward-compatible if we 
> > introduce a boolean option later).
> >
> > The struct refspec field and associated variables are spelled "dst".
> >
> > Part 3 is unchanged.
> 
> It cannot be left unchanged as it is affected by the dest stuff.
> 
> I'll push out a fixed-up one on 'pu' soonish.  Let's stabilize
> this a bit without too many resends.

Yeah, I think we agree on how it should be now, and I'm just confusing myself regenerating patches. Although, possibly, the comment about NULL value should go into documentation for config_fn_t instead, since it's of more general applicability than just this.

	-Daniel
*This .sig left intentionally blank*