Re: [PATCH] wcwidth redeclaration

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 8, 2007, 10:03 UTC
Message-ID: <Pine.LNX.4.64.0705081202080.4167@racer.site>
In-Reply-To: <7vmz0f52no.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 7 May 2007, Junio C Hamano wrote:

Show 15 quoted lines

> apw@us.ibm.com (Amos Waterland) writes:
> 
> > Build fails for git 1.5.1.3 on AIX, with the message: 
> >
> > utf8.c:66: error: conflicting types for 'wcwidth'
> > /.../lib/gcc/powerpc-ibm-aix5.3.0.0/4.0.3/include/string.h:266: error: previous declaration of 'wcwidth' was here
> >
> > Here is a patch that fixes it for me.  If there is a different way that
> > is preferred, please let me know.
> 
> It's static in that file, so renaming our version to our own
> name as you did is perfectly good.
> 
> Thanks for helping, as not many people seem to be on AIX on this
> list.

Thanks indeed. I thought that a static function could shadow a global function, but probably not with a different signature. Just out of curiosity: what is the signature of wcwidth in your string.h?

Ciao, Dscho