Re: [PATCH] Checklist clarifications: added "Commits", "Patch:" headings

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 30, 2007, 12:42 UTC
Message-ID: <Pine.LNX.4.64.0704301442240.29859@racer.site>
In-Reply-To: <Pine.LNX.4.64.0704301306340.2279@reaper.quantumfyre.co.uk>

Hi,

On Mon, 30 Apr 2007, Julian Phillips wrote:

Show 17 quoted lines

> On Mon, 30 Apr 2007, Jari Aalto wrote:
> 
> > Is this workding okay?
> > 
> >        - send your patch to <git@vger.kernel.org> by using
> >          git-format-patch(1) with option "-M". If you use
> >          git-send-email(1), please test it first by sending
> >          email to yourself.
> 
> I don't want to seem picky, but that wording suggests to me that the -M
> option to format-patch magically sends patches to the list.  Why not just
> have:
> 
> 	- use "git format-patch -M" to create the patch
> 	- send your patch to <git@vger.kernel.org>. If you use
> 	  git-send-email(1), please test it first by sending
> 	  email to yourself.

Yes, I like that much better!

Thank you, Dscho