Re: t4201-shortlog.sh does bad things to my terminal

From

Johannes Schindelin <johannes.schindelin@gmx.de>

Date

Apr 23, 2007, 18:46 UTC

Message-ID

<Pine.LNX.4.64.0704232042170.8822@racer.site>

In-Reply-To

<7vmz0zey30.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 23 Apr 2007, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Mon, 23 Apr 2007, Sven Verdoolaege wrote:
> >
> >> It appears that this message is printing a control character to turn off 
> >> echoing, because the terminal appears completely unresponsive 
> >> afterwards. Typing "reset" restores the terminal.
> >> 
> >> Is this really necessary?
> >
> > On both accounts, no. I did not dream of these bytes being interpreted as 
> > control characters.
> >
> > OTOH, you should not need to use --verbose anyway.
> 
> I think it's not Sven but you; you should use --quiet in your
> git commit if the log message has annoying characters.

Ah!

Here's the fix:

Now that git-commit got chatty, we have to shut it up again.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t4201-shortlog.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh
index c27e39c..a48733c 100755
--- a/t/t4201-shortlog.sh
+++ b/t/t4201-shortlog.sh
@@ -15,19 +15,19 @@ commit=$( (echo "Test"; echo) | git commit-tree $tree )
 git update-ref HEAD $commit
 
 echo 2 > a1
-git commit -m "This is a very, very long first line for the commit message to see if it is wrapped correctly" a1
+git commit --quiet -m "This is a very, very long first line for the commit message to see if it is wrapped correctly" a1
 
 # test if the wrapping is still valid when replacing all i's by treble clefs.
 echo 3 > a1
-git commit -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\360\235\204\236')" a1
+git commit --quiet -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\360\235\204\236')" a1
 
 # now fsck up the utf8
 git repo-config i18n.commitencoding non-utf-8
 echo 4 > a1
-git commit -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\370\235\204\236')" a1
+git commit --quiet -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\370\235\204\236')" a1
 
 echo 5 > a1
-git commit -m "a								12	34	56	78" a1
+git commit --quiet -m "a								12	34	56	78" a1
 
 git shortlog -w HEAD > out
 

-- 
1.5.2.rc0.2414.g4e945