Re: [RFD PATCH] git-fetch--tool and "insanely" long actions

From: Julian Phillips <julian@quantumfyre.co.uk>
Date: Apr 20, 2007, 07:40 UTC
Message-ID: <Pine.LNX.4.64.0704200837460.29434@beast.quantumfyre.co.uk>
In-Reply-To: <46281D0B.7080802@gmail.com>

On Thu, 19 Apr 2007, A Large Angry SCM wrote:

Show 11 quoted lines

> Julian Phillips wrote:
>>  On Thu, 19 Apr 2007, A Large Angry SCM wrote:
>> 
>> >  This fixes a problem my repository mirroring script has been having 
>> >  since
>> >  the git-fetch--tool was added to master in the middle of March. However,
>> >  it is not a proper fix since it causes actual errors from snprintf() to 
>> >  be
>> >  ignored. A proper fix is complicated by the lack of a consistent 
>> >  indicator
>> >  that the buffer is too small across snprintf() implementations.

>
> See the last sentence in my original message. Yours also ignores errors from 
> snprintf().
>

Well your last sentence was about the buffer being too small. The change I made means it won't ever be too small. True that it doesn't check for other errors.

-- 
Julian

  ---
You will be successful in your work.