Re: [PATCH] refs.c: add a function to sort a ref list, rather then sorting on add
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Apr 17, 2007, 16:03 UTC
- Message-ID
- <Pine.LNX.4.64.0704170901170.5473@woody.linux-foundation.org>
- In-Reply-To
- <20070417014307.12486.28930.julian@quantumfyre.co.uk>
On Tue, 17 Apr 2007, Julian Phillips wrote:
Show 6 quoted lines
> > Rather than sorting the refs list while building it, sort in one go > after it is built using a merge sort. This has a large performance > boost with large numbers of refs. > > Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Looks fine. I think that even your new times are a bit high (over two seconds?) but things are clearly better. Have you looked at what takes so long now?
Linus