Re: [PATCH 2/4] Refactor patch-id filtering out of git-cherry and git-format-patch.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 14, 2007, 08:57 UTC
Message-ID: <Pine.LNX.4.64.0704141028220.18846@racer.site>
In-Reply-To: <7vmz1fua4r.fsf_-_@assigned-by-dhcp.cox.net>

Hi,

On Tue, 10 Apr 2007, Junio C Hamano wrote:

Show 7 quoted lines

> This implements the patch-id computation and recording library,
> patch-ids.c, and rewrites the get_patch_ids() function used in
> cherry and format-patch to use it, so that they do not pollute
> the object namespace.  Earlier code threw non-objects into the
> in-core object database, and hoped for not getting bitten by
> SHA-1 collisions.  While it may be practically Ok, it still was
> an ugly hack.

No, it was not an ugly hack. Instead, it served as a reminder that we _rely_ on different content having different SHA-1 ids.

Having said that, I do not particularly mind patch-ids being stored elsewhere, if only as a clean up. However, I would have liked your patch so much more if you had done the only sane thing: resurrect object-hash.c.

Now, we have yet another data structure which is unnecessarily bound to a certain use, and the next person wanting a new hashmap needs to add _yet_ another data structure.

Ciao, Dscho