Re: support for large packs and 64-bit offsets
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Apr 9, 2007, 18:02 UTC
- Message-ID
- <Pine.LNX.4.64.0704091059240.6730@woody.linux-foundation.org>
- In-Reply-To
- <20070409171925.GS5436@spearce.org>
On Mon, 9 Apr 2007, Shawn O. Pearce wrote:
> > I like this series. I haven't had time to test it myself yet, > and probably won't be able to do so before Junio merges it into a > pu or next release. But it looks OK on a first read.
Me too.. I just wonder whether it should have some more test coverage: - force v2 index by default - force a mode where a random smattering of index entries are done using 64-bit notation (even if they obviously won't need the high 33 bits)
As it is, nobody would normally even *use* the new format, much less the new capabilities.. And if it's not used, it's not tested, and it's going to have bugs.
Linus