Re: [PATCH] git-apply: Do not free the wrong buffer when we convert the data for writeout

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mar 22, 2007, 20:55 UTC
Message-ID: <Pine.LNX.4.64.0703221355110.6730@woody.linux-foundation.org>
In-Reply-To: <7virctt3yi.fsf_-_@assigned-by-dhcp.cox.net>

On Thu, 22 Mar 2007, Junio C Hamano wrote:

Show 8 quoted lines

> 
> This patch also moves the call to open() up in the function, as
> the caller expects us to fail cheaply if leading directories
> need to be created (and then the caller creates them and calls
> us again).  For that calling pattern, attempting conversion
> before opening the file adds unnecessary overhead.
> 
> Signed-off-by: Junio C Hamano <junkio@cox.net>

Ack, looks good.

		Linus