Re: git 1.5.1-rc1 doesn't like empty files

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mar 20, 2007, 15:45 UTC
Message-ID: <Pine.LNX.4.64.0703200843270.6730@woody.linux-foundation.org>
In-Reply-To: <200703200926.05176.andyparkins@gmail.com>

On Tue, 20 Mar 2007, Andy Parkins wrote:

Show 13 quoted lines

> On Tuesday 2007 March 20 08:49, Junio C Hamano wrote:
> 
> > >> noticed, because almost nobody uses it.
> > >
> > > I'm not sure that's going to be true for long - the 1.5.0 release notes
> > > recommended setting it (assuming you didn't need backward compatibility)
> > > - which is exactly what I (and I'm sure others) did.
> >
> > Well, it is fixed in 'master' to be in -rc2, and that validation
> > does not exist in 'maint', so no harm is done.
> 
> It wasn't the presence of the bug I was highlighting - it was the idea that 
> nobody uses that option.

Yeah, I'm actually happy that people seem to be using it, and it looks like the bug really was totally harmless apart from triggering a bogus error (ie it would never have corrupted anything, it just triggered an error that it shouldn't have).

And I think the only thing that could ever trigger it was really that special case of a zero-sized blob (or maybe an empty tree, but git doesn't generate those natively unless you do magic stuff by hand).

		Linus