Re: Error "fatal: cannot pread pack file: Success"

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Feb 28, 2007, 15:47 UTC
Message-ID: <Pine.LNX.4.64.0702280744150.12485@woody.linux-foundation.org>
In-Reply-To: <7vbqje3jx9.fsf@assigned-by-dhcp.cox.net>

On Tue, 27 Feb 2007, Junio C Hamano wrote:

Show 8 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> >> 
> >> I think the pread() in get_data_from_pack of index-pack is wrong,
> >> it really should be looping until we fill the buffer in case the
> >> OS doesn't fully satisfy our read request the first time.
> 
> The patch looks correct, even if this was not the problem Bill
> is suffering from.

Ack.

Although I would almost prefer it if we just did it like we do a lot of the other cases: call it "xpread()" instead, and have the loop there.

The reason I didn't do that in the first place is that a file access is supposed to be fully satisfied anyway, but yeah, NFS with an interruptible mount will break that posix guarantee, so the loop is definitely the right thing to do.

		Linus