Re: tree corrupted on disk quota full

On Fri, 12 Jan 2007, Michael S. Tsirkin wrote:

Ok, you had an email with "git version" that said 1.5.0-rc0-g<something>, but that may have been after you already upgraded for other reasons.

It would definitely be good to reproduce this - there are multiple places where we could screw up in the presense of a short write. It's also entirely possible that the core code doesn't screw up, but if some of the higher-level scripts don't always check the error code, an error at unpacking time (or some other time) could just go unnoticed.

That said, even though I complain about the "write_in_full()" bug, I think that with the "return error even for partial writes" change it actually _does_ end up being a safer way to do things, so it's entirely possible that while it introduced one bug, it could have fixed another one. The call chain I looked at was just one particular one (it's the most fundamental one for writing out individual objects, so in that sense it's the most likely one, but it's certainly possible that something else happened)

		Linus